Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AI Chat toolbar #3470

Merged
merged 41 commits into from
Nov 4, 2024
Merged

Add AI Chat toolbar #3470

merged 41 commits into from
Nov 4, 2024

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Oct 29, 2024

Task/Issue URL: https://app.asana.com/0/1204167627774280/1208607376873996/f
Tech Design URL:
CC:

Description:
Add AI Chat toolbar icon onboarding flow

Steps to Test This PR:

  1. To start fresh, navigate to the Debug menu and select "AI Chat Reset."
  2. Open the website: https://duck.ai/.
  3. If this is your first time using Duck Chat, complete the onboarding process, then open it again in a new tab.
  4. Check for a popover prompting you to add the toolbar icon.
  5. Click on "Add Shortcut."
  6. Confirm that you see a confirmation message and that the icon remains in the window toolbar.
  7. Verify that in Settings -> AI Chat, the option to display the icon is selected.
  8. Click the icon and ensure that you are redirected to the AI Chat webpage.
  1. Repeat the steps from the first block of tests, but this time open multiple windows. Ensure that the popover is only displayed in the active window.
  1. Follow the same steps as in the first block of tests, but instead of accepting the popover modal, click "No Thanks."
  2. Confirm that the icon is not added to the toolbar.
  3. Check that in Settings -> AI Chat, the option for the toolbar icon is not selected.

Bunn and others added 26 commits October 22, 2024 14:42
@Bunn
WIP: Add AIChat popover
adf7945
@Bunn
WIP: Tab extension to show toolbar popover
b103228
@Bunn
Merge branch 'main' into bunn/aichat/popup-icon
3917339
@Bunn
WIP: Use remote settings for data
3f7a493
@Bunn
Remove URL from AIChatMenuVisibilityConfigurable
d3b6021
@Bunn
Hide button when dismissing popover
39e23ef
@Bunn
Add debug menu
eadfe31
@Bunn
Validate query params
7ae62f3
@Bunn
Fix issue identifying AI Chat url
e1fc373
@Bunn
improve settings code
cb8044f
@Bunn
WIP: Confirmation popover
d2b0672
@Bunn
Use PopoverMessageViewController
577d88a
@Bunn
Fix callbacks
651d604
@Bunn
Add text to userText
d922706
@Bunn
Add settings tests
3070e3f
@Bunn
Fix configuration tests
dbfc798
@Bunn
Bubble up dependency
a2bb436
@Bunn
Add extension tests
ed7dcea
@Bunn
Merge branch 'main' into bunn/aichat/popup-icon
2ce137f
@Bunn
Linter
da0aba6
@Bunn
Fix header
d1d5c78
@Bunn
Add documentation to protocol
c59b611
@samsymons @Bunn
Fix tooltip messaging.
bfb68f3
@samsymons @Bunn
Show AI chat in the menus by default.
7e92c0d
@Bunn
Merge branch 'release/1.112.0' into bunn/aichat/branch-from-head-pop-…
c341548 
…icon

# Conflicts:
#	DuckDuckGo/Preferences/View/PreferencesViewController.swift
@Bunn
Fix issue with navigation from same document
7ec0bdc
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 107464c

jotaemepereira
jotaemepereira approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bunn Functionality-wise, it looks excellent 👍🏼 .

I’ve added a comment around tests. What do you think of implementing the suggestions before merging?

DuckDuckGo/AIChat/AIChatDebugMenu.swift Show resolved Hide resolved
UnitTests/AIChat/AIChatMenuConfigurationTests.swift Show resolved Hide resolved
@Bunn Bunn changed the base branch from release/1.112.0 to main October 30, 2024 18:34
@Bunn Bunn merged commit f21203d into main Nov 4, 2024
18 checks passed
@Bunn Bunn deleted the bunn/aichat/branch-from-head-pop-icon branch November 4, 2024 13:58
samsymons added a commit that referenced this pull request Nov 4, 2024
@samsymons
Merge branch 'main' into sam/vpn-clean-up
46aebd2 
# By Dax the Duck (4) and others
# Via GitHub (2) and Dax the Duck (1)
* main:
  Bump version to 1.113.0 (298)
  Bump version to 1.113.0 (297)
  Set marketing version to 1.113.0
  Update embedded files
  Add AI Chat toolbar (#3470)
  disable testWhenSnapshotIsRestored_ThenRenderingIsSkippedAfterLoading (#3483)
  Add Privacy Config feature to control ad attribution reporting (#3478)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotaemepereira jotaemepereira jotaemepereira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bunn @jotaemepereira @samsymons