Freemium PIR: Manual Removal Links #3466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aataraxiaa
changed the title
quanganhdo
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Works well, nice test coverage. I left one non-blocking comment.
Some notes:
- The Reset Premium Feature State step should be done first. I couldn't get the entry points to show up until Enroll into Experiment is done after.
- The FE UI doesn't show the opt out URL so there's no way to test if it works.
- (FE comment) Hovering the test results should change the cursor to indicate they're clickable.
Comment on lines
245
to
254
| /// A computed property that determines if the `optOutUrl` belongs to the parent broker instead of this broker. | ||
| /// | ||
| /// This property returns `true` if the `optOutUrl` does not contain the main `url` of the broker, | ||
| /// indicating that the opt-out URL is associated with a parent broker. Conversely, it returns `false` | ||
| /// if the `optOutUrl` includes the broker's `url`, signifying that the opt-out URL belongs directly to this broker. | ||
| /// | ||
| /// - Returns: `true` if the `optOutUrl` is for a parent broker; `false` if it is for this broker. | ||
| var optOutUrlIsParent: Bool { | ||
| !optOutUrl.contains(url) | ||
| } |
There was a problem hiding this comment.
What's this for? Looks like it's only used in test cases.
There was a problem hiding this comment.
Thanks @quanganhdo. Removed this code and related tests.
samsymons
added a commit
that referenced
this pull request
Nov 4, 2024
# By Dax the Duck (5) and others # Via GitHub (4) and Michal Smaga (1) * main: (24 commits) Validate VPN errors before re-throwing them (#3490) Allowing users to delete suggestions (#3430) Bump version to 1.112.0 (296) Marking latest Bitwarden versions as incompatible (#3492) Bump version to 1.112.0 (295) Update to subscription cookie (#3489) Bug Fix: Phishing Detection Dataset Discrepancies (#3440) Bump version to 1.112.0 (294) Fix crash when opening permission popover for NewTab page address bar (#3484) Set version_check_wait_retry_limit to 1 (#3488) Refactor automatic update flow to use custom Sparkle user driver (#3274) Add to Dock - Update BSK version (#3479) Freemium PIR: Manual Removal Links (#3466) Fix Sync E2E tests (#3486) Fix crash on empty bookmarks html root element (#3482) update UI test (#3469) Update BSK with autofill 15.1.0 (#3480) Bump version to 1.112.0 (293) New tagline (#3401) add system info to webkit termination validation (#3473) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208619435900636/f
FE PR: https://dub.duckduckgo.com/duckduckgo/static-pages/pull/1012
Description: Adds a manual removal link to each Freemium PIR result record view
Note: The frontend UI is in flux. However, the native work can be tested
Test Prerequisites
Relaunch the browser
Steps to test this PR:
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation