Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tagline #3401

Merged
merged 2 commits into from
Oct 30, 2024
Merged

New tagline #3401

merged 2 commits into from
Oct 30, 2024

Conversation

quanganhdo
Copy link
Member

@quanganhdo quanganhdo commented Oct 15, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1205591970852438/1208504563612286/f
Tech Design URL:
CC:

Description:

Updates new tagline.

Steps to test this PR:

  1. Check the About page

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@quanganhdo
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @quanganhdo and the rest of your teammates on Graphite Graphite

@quanganhdo quanganhdo marked this pull request as ready for review October 15, 2024 21:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against c558f27

@quanganhdo quanganhdo requested review from a team, jaceklyp and federicocappelli and removed request for a team and jaceklyp October 15, 2024 22:20
federicocappelli
federicocappelli approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Suggestion: should we write the new tagline in a single place (like some test utilities) and re-use it across all UI tests instead than duplicate it many times?

@quanganhdo
Copy link
Member Author

@federicocappelli That sounds overkill to me; how often do the tagline need to be updated? :D

@federicocappelli
Copy link
Member

@federicocappelli That sounds overkill to me; how often do the tagline need to be updated? :D

Not the point, the localisation script every time is run extracts all these strings and localise them. A string should be in a single place for the same reason we use constants around the code, duplication can bring to mistakes.
But up to you, it's already approved.

@quanganhdo quanganhdo merged commit fc7eaf4 into main Oct 30, 2024
18 checks passed
@quanganhdo quanganhdo deleted the anh/new-tagline branch October 30, 2024 20:15
samsymons added a commit that referenced this pull request Nov 4, 2024
@samsymons
Merge branch 'main' into sam/vpn-clean-up
c4629fa 
# By Dax the Duck (5) and others
# Via GitHub (4) and Michal Smaga (1)
* main: (24 commits)
  Validate VPN errors before re-throwing them (#3490)
  Allowing users to delete suggestions (#3430)
  Bump version to 1.112.0 (296)
  Marking latest Bitwarden versions as incompatible (#3492)
  Bump version to 1.112.0 (295)
  Update to subscription cookie (#3489)
  Bug Fix: Phishing Detection Dataset Discrepancies (#3440)
  Bump version to 1.112.0 (294)
  Fix crash when opening permission popover for NewTab page address bar (#3484)
  Set version_check_wait_retry_limit to 1 (#3488)
  Refactor automatic update flow to use custom Sparkle user driver (#3274)
  Add to Dock - Update BSK version (#3479)
  Freemium PIR: Manual Removal Links (#3466)
  Fix Sync E2E tests (#3486)
  Fix crash on empty bookmarks html root element (#3482)
  update UI test (#3469)
  Update BSK with autofill 15.1.0 (#3480)
  Bump version to 1.112.0 (293)
  New tagline (#3401)
  add system info to webkit termination validation (#3473)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicocappelli federicocappelli federicocappelli approved these changes

Assignees
No one assigned
Labels
pending ship review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quanganhdo @federicocappelli