Add support for skipping sending usage pixels for remote messages #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
6 tasks
ayoy
commented
Jul 18, 2024
| @@ -62,6 +62,7 @@ struct RemoteMessageView: View { | |||
| .padding(.vertical, 14) | |||
| } | |||
| .padding(.bottom, 32) | |||
| .onAppear(perform: viewModel.onDidAppear) | |||
There was a problem hiding this comment.
This thing was missing from the original implementation 🙈 it's also included in another PR that's targeted towards the release branch for next week's release
quanganhdo
approved these changes
Jul 19, 2024
samsymons
added a commit
that referenced
this pull request
Jul 19, 2024
# By Tom Strba (3) and others # Via GitHub (2) and Dominik Kapusta (1) * main: SERP version flag removed (#2998) Fix VPN configuration removal to stop the tunnel (#2991) Readme & Contribute changes (#2982) Automatic updates (#2938) Add support for skipping sending usage pixels for remote messages (#2994) Bump version to 1.97.0 (229) Update vertical spacing in New Tab Page (#2986) Bump version to 1.97.0 (228) VPN no longer binds to a fixed listening port (#2992) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Jul 19, 2024
# By Dax the Duck (3) and others # Via GitHub (3) and Dominik Kapusta (1) * main: Add attribute for checking for deprecated Mac remote message interaction (#2995) SERP version flag removed (#2998) Fix VPN configuration removal to stop the tunnel (#2991) Readme & Contribute changes (#2982) Automatic updates (#2938) Add support for skipping sending usage pixels for remote messages (#2994) Bump version to 1.97.0 (229) Update vertical spacing in New Tab Page (#2986) Bump version to 1.97.0 (228) Bump Submodules/privacy-reference-tests from `a603ff9` to `afb4f61` (#2984) Updates BSK 171.2.3 VPN no longer binds to a fixed listening port (#2992) Bump version to 1.97.0 (227) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201621708115095/1207841204698435/f
Description:
This change allows to skip sending usage pixels for a given remote message if that's stated in the RMF config.
Steps to test this PR:
See BSK PR for steps to test.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation