Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open in new Fire Window link option #2967

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1204517122485752/1205239588622491/f

Description:

  • Add Open in new Fire Window context menu option for links

Steps to test this PR:

  1. Open some website,
  2. Right click a link,
  3. Hold Option, Open Link in new Fire Window option should appear
  4. Validate it opens a new fire window with the link opened
  5. Right click a link in the Fire Window, hold Option, validate there‘s no such option.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

🚫 The Asana task linked in the PR description is not added to macOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • ⚠️ Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to macOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant