Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary notification pixels #2803

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

samsymons
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1193060753475688/1207145810980144/f
Tech Design URL:
CC:

Description:

Removes changes from #2681

Steps to test this PR:

  1. Check that the VPN connects and you still get notifications when connected

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@samsymons samsymons requested a review from quanganhdo May 22, 2024 00:45
Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

* main: (33 commits)
  Remove autofill survey (#2819)
  Bump version to 1.90.0 (192)
  Set marketing version to 1.90.0
  Update embedded files
  Privacy Pro survey support (#2816)
  Update PeopleWhiz Broker Files to use hash id (#2814)
  Update BSK due to iOS changes. (#2776)
  Scroll address bar to caret when using arrows (#2799)
  Privacy Pro macOS quick follow ups (#2813)
  BSK bump for iOS RMF updates (#2798)
  Autofill engagement KPIs for pixel reporting (#2806)
  autofill: don't prefix autofill email pixels with `m.mac.` (#2808)
  Bump BSK (#2807)
  Make profile selector optional (#2811)
  Add History to iOS (updated UI and rollout) (#2770)
  New autofill save & update password prompt pixels for alignment with iOS (#2801)
  Add mylife data broker (#2786)
  Increase test timeout (#2810)
  Subscription refactoring, BSK update (#2809)
  Check for entitlement in DBP agent (#2802)
  ...
@github-actions github-actions bot removed the stale label May 31, 2024
* main:
  Add optional "multiple" property to PageElement (#2827)
  Update BSK for iOS RMF changes (#2831)
  Bump version to 1.91.0 (197)
  Set marketing version to 1.91.0
  Update embedded files
  DBP: Enable DBP Operations to Run When Device is Locked (#2797)
  Update autoconsent to v10.9.0 (#2822)
  Bump version to 1.90.0 (196)
  Revert "Add PIPAgent entitlement (#2821)" (#2823)
  Bump version to 1.90.0 (195)
  Bump version to 1.90.0 (194)
  Add PIPAgent entitlement (#2821)
  Fixes some VPN uninstallation issues (#2820)
  Bump version to 1.90.0 (193)
  Remove autofill survey (#2819)
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some test is failing I believe, but this is otherwise good to go.

* main:
  DBP: Implement exponential backoff for optout retries (#2815)
  Update UI Tests CI workflows for macOS 13/14 (#2835)
  Display the addresses in the Debugger UI (#2828)
  Removing temporary password manager survey code (#2834)
  Surface specific XPC & login item errors (#2773)
  DuckPlayer PiP settings (#2830)
@samsymons samsymons merged commit 62e901e into main Jun 5, 2024
19 checks passed
@samsymons samsymons deleted the sam/remove-netp-notification-pixels branch June 5, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants