Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for entitlement in DBP agent #2802
Check for entitlement in DBP agent #2802
Changes from 3 commits
a33ad82
d0a43b1
8152027
cf789fe
a1a17a9
821112e
37a4515
e3b5d00
4870a05
7a950d4
53d8106
3367dd3
5b973bf
29eea91
3d67be5
d78c22e
42264a4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 42 in DuckDuckGo/DBP/DataBrokerProtectionSubscriptionEventHandler.swift
GitHub Actions / Make Release Build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: I don’t think it will cause issues, but something about the protocol extension referencing the concrete type static variable seems strange, or inverted. Maybe it’s a pattern, unsure, but wanted to highlight. Other options would be to just declare the constant in the function, or if we want every concrete type to have it’s own interval, define
monitoringInterval
as a protocol requirement.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declaring the const in the function is the way to go IMO. The static const there is a leftover from some tests. Good call, thanks. I'll fix it
Check failure on line 293 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Scheduler/DataBrokerProtectionAgentManager.swift
GitHub Actions / SwiftLint
Check warning on line 62 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Test (Non-Sandbox)
Check warning on line 62 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Test (Non-Sandbox)
Check warning on line 62 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Make Release Build
Check warning on line 62 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Make Release Build
Check warning on line 62 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Test (Non-Sandbox)
Check warning on line 65 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Test (Non-Sandbox)
Check warning on line 65 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Test (Non-Sandbox)
Check warning on line 65 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Make Release Build
Check warning on line 65 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Make Release Build
Check warning on line 65 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Test (Non-Sandbox)
Check warning on line 67 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Test (Non-Sandbox)
Check warning on line 67 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Test (Non-Sandbox)
Check warning on line 67 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Make Release Build
Check warning on line 67 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Make Release Build
Check warning on line 67 in LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Utils/DataBrokerProtectionAgentStopper.swift
GitHub Actions / Test (Non-Sandbox)