Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New autofill save & update password prompt pixels for alignment with iOS #2801

Merged
merged 5 commits into from
May 23, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented May 21, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1207361449520263/f
Tech Design URL:
CC:

Description:
New pixels to bring macOS password management pixel reporting up to date with iOS

Steps to test this PR:

Using DuckDuckGo as your Password Manager:

Save Login

  1. Visit https://fill.dev/form/login-simple and enter new credentials (both username and password) and click Login
  2. Confirm the pixel m_mac_autofill_logins_save_login_inline_displayed fires when the Save prompt appears
  3. Click Don't Save and confirm the pixel m_mac_autofill_logins_save_login_inline_dismissed is fired
  4. Repeat Step 1, but this time click Save and confirm the pixel m_mac_autofill_logins_save_login_inline_confirmed is fired

Update Password

  1. Go back to https://fill.dev/form/login-simple and choose the credentials saved as part of Save Login but modify the password and click Login
  2. Confirm the pixel m_mac_autofill_logins_update_password_inline_displayed fires when the prompt appears
  3. Click Don't Update
  4. Confirm the pixel m_mac_autofill_logins_update_password_inline_dismissed fires
  5. Repeat Step 1
  6. Click Update and confirm that the pixel m_mac_autofill_logins_update_password_inline_confirmed fires
  7. Repeat Step 1 but this time also modify the username in the prompt
  8. Click Update and confirm that both pixels m_mac_autofill_logins_update_username_inline_confirmed and m_mac_autofill_logins_update_password_inline_confirmed are fired (since both were modified)

Save Password

  1. Visit https://news.ycombinator.com/login and enter a (min 4 char) password (no username) and click login
  2. Confirm the pixel m_mac_autofill_logins_save_password_inline_displayed fires when the Save prompt appears
  3. Click Don't Save and confirm the pixel m_mac_autofill_logins_save_password_inline_dismissed is fired
  4. Repeat Step 1, but this time click Save and confirm the pixel m_mac_autofill_logins_save_password_inline_confirmed is fired

Update Username

  1. On https://news.ycombinator.com/login enter a username and using the previously saved password click login
  2. Confirm the pixel m_mac_autofill_logins_update_username_inline_displayed fires when the prompt appears
  3. Click Don't Update and confirm the pixel m_mac_autofill_logins_update_username_inline_dismissed fires
  4. Repeat Step 1 but this time click Update and confirm the pixel m_mac_autofill_logins_update_username_inline_confirmed fires

Bitwarden

  1. Update your password manager to be Bitwarden and repeat the steps from sections Save Login and Save Password confirming the same pixels fire

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@amddg44 amddg44 requested a review from SabrinaTardio May 21, 2024 14:02
Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! LGTM
I left 2 small comments

@amddg44 amddg44 merged commit d826ec2 into main May 23, 2024
25 of 26 checks passed
@amddg44 amddg44 deleted the anya/autofill-pixels-ios-parity branch May 23, 2024 14:45
samsymons added a commit that referenced this pull request May 23, 2024
# By Fernando Bunn (3) and others
# Via GitHub
* main:
  Autofill engagement KPIs for pixel reporting (#2806)
  autofill: don't prefix autofill email pixels with `m.mac.` (#2808)
  Bump BSK (#2807)
  Make profile selector optional (#2811)
  Add History to iOS (updated UI and rollout) (#2770)
  New autofill save & update password prompt pixels for alignment with iOS (#2801)
  Add mylife data broker (#2786)
  Increase test timeout (#2810)
  Subscription refactoring, BSK update (#2809)
  Check for entitlement in DBP agent (#2802)
  move permanent survey card to first position (#2804)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
samsymons added a commit that referenced this pull request May 24, 2024
# By Elle Sullivan (8) and others
# Via Elle Sullivan (3) and GitHub (2)
* main: (26 commits)
  Autofill engagement KPIs for pixel reporting (#2806)
  autofill: don't prefix autofill email pixels with `m.mac.` (#2808)
  Bump BSK (#2807)
  Make profile selector optional (#2811)
  Add History to iOS (updated UI and rollout) (#2770)
  New autofill save & update password prompt pixels for alignment with iOS (#2801)
  Add mylife data broker (#2786)
  Increase test timeout (#2810)
  Subscription refactoring, BSK update (#2809)
  Check for entitlement in DBP agent (#2802)
  move permanent survey card to first position (#2804)
  Subscription refactoring (#2764)
  Bump version to 1.89.0 (191)
  Merge pir stabilization feature branch into main (#2789)
  Update age params for multiple brokers (#2800)
  Fix top level navigation blocks (#2792)
  Adding to the Dock automatically (#2722)
  Fix lint error
  Make activity only call completion once all work has actually finished
  Fix activity scheduler not calling completion
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request May 30, 2024
* main: (33 commits)
  Remove autofill survey (#2819)
  Bump version to 1.90.0 (192)
  Set marketing version to 1.90.0
  Update embedded files
  Privacy Pro survey support (#2816)
  Update PeopleWhiz Broker Files to use hash id (#2814)
  Update BSK due to iOS changes. (#2776)
  Scroll address bar to caret when using arrows (#2799)
  Privacy Pro macOS quick follow ups (#2813)
  BSK bump for iOS RMF updates (#2798)
  Autofill engagement KPIs for pixel reporting (#2806)
  autofill: don't prefix autofill email pixels with `m.mac.` (#2808)
  Bump BSK (#2807)
  Make profile selector optional (#2811)
  Add History to iOS (updated UI and rollout) (#2770)
  New autofill save & update password prompt pixels for alignment with iOS (#2801)
  Add mylife data broker (#2786)
  Increase test timeout (#2810)
  Subscription refactoring, BSK update (#2809)
  Check for entitlement in DBP agent (#2802)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants