Fix a division-by-zero crash in the VPN code #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
changed the title
diegoreymendez
changed the title
diegoreymendez
changed the title
This was referenced May 15, 2024
github-actions
bot
added
the
bot: not in app board
mallexxx
approved these changes
May 16, 2024
diegoreymendez
removed
the
bot: not in app board
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
May 17, 2024
Task/Issue URL: https://app.asana.com/0/1203137811378537/1207299387361586/f iOS PR: duckduckgo/iOS#2862 macOS PR: duckduckgo/macos-browser#2785 What kind of version bump will this require?: Patch ## Description Fixes a crash caused by a division by zero.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
May 17, 2024
Task/Issue URL: https://app.asana.com/0/1203137811378537/1207299387361586/f macOS PR: duckduckgo/macos-browser#2785 BSK PR: duckduckgo/BrowserServicesKit#823 ## Description Fixes a crash caused by a division by zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203137811378537/1207299387361586/f
iOS PR: duckduckgo/iOS#2862
BSK PR: duckduckgo/BrowserServicesKit#823
Description
Fixes a crash caused by a division by zero.
Testing
Just ensure the VPN starts correctly, works, stops, etc.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation