Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run more parallel operations on manual scans #2748

Merged

Conversation

jotaemepereira
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1204006570077678/1206981742767461/f
Tech Design URL:
CC:

Description:
Runs more parallel operations when the operation is manual scans. We want to increase the number only for manual scans, other operations should be kept to six for the moment.

I also renamed the configuration file, is not related to the scheduler. I also refactored to just be a struct, we do not need to make it a protocol, if we want to mock it we can just initialize it with the values that we want.

Steps to test this PR:

  1. Run manual scans showing the web views. Check that six windows are opened
  2. Run queued operations showing web views. Check that two windows are opened

@jotaemepereira jotaemepereira requested a review from Bunn May 6, 2024 19:50
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jotaemepereira 👍🏼

@jotaemepereira jotaemepereira merged commit 1c65660 into main May 7, 2024
26 checks passed
@jotaemepereira jotaemepereira deleted the juan/dbp/set-max-parallel-operation-on-initial-scan branch May 7, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants