Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixels fixes #2747

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DuckDuckGo/Application/AppDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ final class AppDelegate: NSObject, NSApplicationDelegate {
.filter { $0 }
.asVoid()
.sink { [weak syncService] in
PixelKit.fire(GeneralPixel.syncDaily, frequency: .daily)
PixelKit.fire(GeneralPixel.syncDaily, frequency: .legacyDaily)
syncService?.syncDailyStats.sendStatsIfNeeded(handler: { params in
PixelKit.fire(GeneralPixel.syncSuccessRateDaily, withAdditionalParameters: params)
})
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/Fire/ViewModel/FirePopoverViewModel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ final class FirePopoverViewModel {
// MARK: - Burning

func burn() {
PixelKit.fire(GeneralPixel.fireButtonFirstBurn, frequency: .daily)
PixelKit.fire(GeneralPixel.fireButtonFirstBurn, frequency: .legacyDaily)

switch (clearingOption, areAllSelected) {
case (.currentTab, _):
Expand Down
22 changes: 11 additions & 11 deletions DuckDuckGo/Statistics/GeneralPixel.swift
Original file line number Diff line number Diff line change
Expand Up @@ -386,22 +386,22 @@ enum GeneralPixel: PixelKitEventV2 {
return "m_mac_\(pixel.pixelName)"
}
case .emailEnabledInitial:
return "m_mac.enable-email-protection.initial"
return "m_mac_enable-email-protection_initial"

case .watchInDuckPlayerInitial:
return "m_mac.watch-in-duckplayer.initial"
return "m_mac_watch-in-duckplayer_initial"
case .setAsDefaultInitial:
return "m_mac.set-as-default.initial"
return "m_mac_set-as-default_initial"
case .importDataInitial:
return "m_mac.import-data.initial"
return "m_mac_import-data_initial"
case .newTabInitial:
return "m_mac.new-tab-opened.initial"
return "m_mac_new-tab-opened_initial"
case .favoriteSectionHidden:
return "m_mac.favorite-section-hidden"
return "m_mac_favorite-section-hidden"
case .recentActivitySectionHidden:
return "m_mac.recent-activity-section-hidden"
return "m_mac_recent-activity-section-hidden"
case .continueSetUpSectionHidden:
return "m_mac.continue-setup-section-hidden"
return "m_mac_continue-setup-section-hidden"

// Fire Button
case .fireButtonFirstBurn:
Expand Down Expand Up @@ -434,11 +434,11 @@ enum GeneralPixel: PixelKitEventV2 {
return "m_mac_mp_wlr"

case .launchInitial:
return "m.mac.first-launch"
return "m_mac_first-launch"
case .serpInitial:
return "m.mac.navigation.first-search"
return "m_mac_navigation_first-search"
case .serpDay21to27:
return "m.mac.search-day-21-27.initial"
return "m_mac_search-day-21-27_initial"

case .vpnBreakageReport:
return "m_mac_vpn_breakage_report"
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/Tab/TabExtensions/DuckPlayerTabExtension.swift
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ extension DuckPlayerTabExtension: NavigationResponder {
return
}
if navigation.url.isDuckPlayer {
PixelKit.fire(GeneralPixel.duckPlayerDailyUniqueView, frequency: .daily)
PixelKit.fire(GeneralPixel.duckPlayerDailyUniqueView, frequency: .legacyDaily)
}
}

Expand Down
Loading