Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autocomplete pixels #2746

Merged
merged 2 commits into from
May 7, 2024
Merged

Add Autocomplete pixels #2746

merged 2 commits into from
May 7, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented May 6, 2024

Task/Issue URL: https://app.asana.com/0/1177771139624306/1207226295114884/f

Description:
This change adds a bunch of pixels related to selecting suggestions in the address bar.

Steps to test this PR:

  1. Go to Settings -> General
  2. Toggle autocomplete checkbox. Verify that it emits m_mac_autocomplete_toggled_on and m_mac_autocomplete_toggled_off as expected.
  3. Add 2 bookmarks, mark one of them as favorite.
  4. Keep autocomplete selected.
  5. Type a phrase in the address bar and click on a search phrase suggestion. Verify that it emits m_mac_autocomplete_click_phrase.
  6. Type a website address in the address bar and click on a website suggestion. Verify that it emits m_mac_autocomplete_click_website.
  7. Type the bookmark name and click on a bookmark suggestion. Verify that it emits m_mac_autocomplete_click_bookmark.
  8. Type the favorite name and click on a bookmark suggestion. Verify that it emits m_mac_autocomplete_click_favorite.
  9. Type part of the address/title of a website you've visited previously. Click on a history suggestion. Verify that it emits m_mac_autocomplete_click_history.
  10. Verify that 5-9 also work for selecting the suggestion using keyboard (navigating with keys and pressing Enter).

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy requested a review from SabrinaTardio May 6, 2024 17:39
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 6, 2024
@ayoy ayoy removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label May 6, 2024
Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayoy ayoy merged commit 6fc3f17 into main May 7, 2024
19 checks passed
@ayoy ayoy deleted the dominik/autocomplete-pixels branch May 7, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants