Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1207226295114884/f
Description:
This change adds a bunch of pixels related to selecting suggestions in the address bar.
Steps to test this PR:
m_mac_autocomplete_toggled_on
andm_mac_autocomplete_toggled_off
as expected.m_mac_autocomplete_click_phrase
.m_mac_autocomplete_click_website
.m_mac_autocomplete_click_bookmark
.m_mac_autocomplete_click_favorite
.m_mac_autocomplete_click_history
.Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation