Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Clear This History.." for today burns windows #2745

Merged
merged 3 commits into from
May 8, 2024

Conversation

tomasstrba
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1177771139624306/1207195823454499/f

Description:
When user selects "Clear This History" from the history menu to clear history for today, we have to burn windows too.

Steps to test this PR:

  1. Open bunch of tabs and visit few websites
  2. Click on "Clear This History" from the History menu for other day than today
  3. Make sure all windows and current tabs remain open
  4. Click on "Clear This History" from the History menu for today
  5. Make sure windows and tabs are cleared

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@tomasstrba tomasstrba requested a review from alessandroboron May 6, 2024 09:17
Copy link
Contributor

@alessandroboron alessandroboron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I just left a suggestion, but it’s a non-blocker.

@tomasstrba tomasstrba merged commit 17047bd into main May 8, 2024
19 checks passed
@tomasstrba tomasstrba deleted the tom/clear-this-history-fix branch May 8, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants