-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync error notify user #2712
sync error notify user #2712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SabrinaTardio I'm leaving a bunch of comments related to naming and code placement.
It is ready to be reviewed again… please not the change in 400 error behaviour that now is expected to behave as 413 and 409 |
…os-browser into sabrina/sync-error-notify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I'm loving the changes, great job 💪
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207178541221451/f
Description: Notify user of more sync errors https://app.asana.com/0/0/1207045332341265/f
Steps to test this PR:
Errors on the menu
Alerts For errors 400, 401, 409 and 413
Alerts For errors 418 and 429
The alert should only appear if:
The error occurs consecutively (no successful sync is registered in between) 10 times indicating a persistent issue OR
No successful sync (after an error) has occurred in 12 hours.
We will only show the error once a day (if 10 times are hit again within the day we will not show it again)
To test this please use the user default data:
"sync.last-error-notification-time” -> which is a Date
"sync.last-time-success” -> which is a Date
"sync.non-actionable-error-count” -> number of times the error is triggered and is an integer
--
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation