Address tab feedback #2705
Merged
Address tab feedback #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207117125840765/f Tech Design URL: CC: @ayoy **Description**: This PR adds the option to close all tabs to the left when right clicking a tab. It also moves this action as well as "close to right" and "close other tabs" to a submenu in the tab context menu. **Steps to test this PR**: 1. Open some tabs 2. Right click a tab, ensure "Close Other Tabs" opens a sub menu 3. Clicking "Close Tabs to the Left" should close all tabs to the left of the clicked tab except pinned tabs 4. "Close to the right" and "Close all other tabs" should work as expected. <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f) --------- Co-authored-by: Dominik Kapusta <[email protected]>
Task/Issue URL: https://app.asana.com/0/0/1207132177515791/f Tech Design URL: CC: **Description**: This PR adds an option in settings that will switch to a new tab when a link is opened **Steps to test this PR**: 1. Turn on the new option under "Tabs" in settings 2. Go to https://reddit.com/r/news 3. Click an article link, a new tab should be opened and focused 4. Go back to the reddit tab 5. Right click an article link and click "Open link in new tab" 6. A new tab should open and be focussed <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
…os-browser into brad/address-tab-feedback
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207132177515800/f Tech Design URL: CC: @ayoy **Description**: This PR adds an option to prefer opening new tabs instead of windows when opening links. This new option defaults to enabled. **Steps to test this PR**: 1. Open https://wikipedia.org. CMD+click a link, it should open in a new tab 2. Open settings. Disable "Prefer new tabs" under general 3. Repeat step 1, it should open a new window 4. Go to https://reddit.com/r/news 5. Click an article link, it should open in a new window <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207132178310556/f Tech Design URL: CC: **Description**: This PR adds an option to set the position of new tabs opened by the new tab button, the file menu, and cmd+T **Steps to test this PR**: 1. Open some tabs using the 3 methods above, they should always open at the end of the list 2. Go to settings > general and set the new tab position setting to "Next to current tab" 3. Repeat step 1, the tabs should always open next to the current tab, if the selected tab is a pinned tab it should open next to the pinned tabs. <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
ayoy
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
All looks and works great 💪 be sure to let me know if you need another review for any changes that may be requested during ship review. Thanks @SlayterDev!
ayoy
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207132178310556/f
Tech Design URL:
CC: @ayoy
Description:
Ship review for "Address tab management feedback"
Steps to test this PR:
1.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation