Fix bookmarks and fav rearrangement #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
bwaresiak
removed
the
bot: not in app board
ayoy
approved these changes
Apr 29, 2024
Comment on lines
326
to
342
| let folderMO = BookmarkEntity.makeFolder(title: "Parent", parent: rootMO, context: context) | ||
|
|
||
| let bookmark1MO = BookmarkEntity.makeBookmark(title: "Example 1", url: "https://example1.com", parent: folderMO, | ||
| context: context) | ||
| let bookmark2MO = BookmarkEntity.makeBookmark(title: "Example 2", url: "https://example2.com", parent: folderMO, | ||
| context: context) | ||
| let bookmarkStub1MO = BookmarkEntity.makeBookmark(title: "Stub 1", url: "", parent: folderMO, | ||
| context: context) | ||
| bookmarkStub1MO.isStub = true | ||
| let bookmarkStub2MO = BookmarkEntity.makeBookmark(title: "Stub 2", url: "", parent: folderMO, | ||
| context: context) | ||
| bookmarkStub2MO.isStub = true | ||
| let bookmark3MO = BookmarkEntity.makeBookmark(title: "Example 3", url: "https://example3.com", parent: folderMO, | ||
| context: context) | ||
| let bookmarkStub3MO = BookmarkEntity.makeBookmark(title: "Stub 3", url: "", parent: folderMO, | ||
| context: context) | ||
| bookmarkStub3MO.isStub = true |
There was a problem hiding this comment.
We could export BookmarksTestsUtils from BSK package and use it here, but fine to do it at a later time 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201493110486074/1207136222342904/f
Tech Design URL:
CC:
Description:
Expand test suite to cover stub objects when rearranging Bookmarks.
Steps to test this PR:
Check the tests that've been added.
Go to Debug -> Sync -> Populate Stub Objects. This will create a mix of stub and non stub objects in both root folder and favorite folders. Test rearranging of both regular bookmarks and favorites.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation