Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Settings Page Updates #2678

Conversation

aataraxiaa
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1207044475588306/f

Description:
Updates the ‘Passwords’ Settings page

Steps to test this PR:

  1. Open Settings/Passwords -> Ensure there are now separate entry points for each Autofill type - “View Passwords...”, “View Payment Methods…”, and “View Identities"
  2. Open Settings/Passwords -> The import/export buttons titles should now be “Import passwords” and “Export passwords” (this should also be reflected in the Autofill dialog overflow menu)
  3. Open Settings/Passwords -> “Save and Autofill” should now be “Ask to save and Autofill"
  4. Open Settings/Passwords -> Under “Ask to save and Autofill”, “Usernames and passwords” should now be “Passwords"

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 22, 2024
@aataraxiaa aataraxiaa requested a review from amddg44 April 22, 2024 15:39
@aataraxiaa aataraxiaa removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 22, 2024
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just a couple of small things:

  • I think the copy should actually be "Ask to Save and Autofill" (capital S on Save) based on the copy review task (I think it's a typo in figma but feel free to correct me here!)
  • Not part of the scope of this PR, but maybe it would nicer if the order of the options was the same in both of these sections, wdyt?
    image

@aataraxiaa
Copy link
Contributor Author

Thanks @amddg44, I’ve made changes to address both comments. 🚀

@aataraxiaa aataraxiaa merged commit 900a629 into feature/pete/make-passwords-easier-to-discover Apr 24, 2024
16 checks passed
@aataraxiaa aataraxiaa deleted the pete/password-settings-page-updates branch April 24, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants