Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBP expand xpc error pixels #2667

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Conversation

THISISDINOSAUR
Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR commented Apr 19, 2024

Task/Issue URL: https://app.asana.com/0/0/1207116442690809/f
Tech Design URL:
CC:

Description:
Adds a whole slew of pixels to close our data gap on running scanAllBrokers, including separating out existing parameters into pixels. See task for details.
It also:

  • Adds proper handling for interrupting ongoing scans, which will close our large data gap
  • Stops us trying to call scanAllBrokers if we don't have the correct loginItem permissions or if we are in the wrong directory.

Don't merge, privacy triage pending

Steps to test this PR:

  1. One key thing is to make sure DBP still works as expected
  2. Go through each of the new pixels and make sure each fires as expected. Generally speaking, we should never call scanAllBrokers without firing a pixel on both the app and the agent, and same for it completing (and also in general should never fire two pixels for the same event, the exception being initially calling scan all brokers, and the pixels for if we don't have the permissions/directory, since I thought that way around would be easier to deal with in grafana)

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 19, 2024
@THISISDINOSAUR THISISDINOSAUR removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Apr 19, 2024
@THISISDINOSAUR THISISDINOSAUR requested a review from Bunn April 19, 2024 16:05
Copy link
Collaborator

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Tested the full scan/opt-out flow and it's working as expected.
I see the pixels being sent, also forced the interrupted pixel and it worked

@THISISDINOSAUR THISISDINOSAUR merged commit a937e9e into main Apr 22, 2024
16 checks passed
@THISISDINOSAUR THISISDINOSAUR deleted the elle/dbp-expand-xpc-error-pixels branch April 22, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants