Support close tabs to left and move close actions to submenu #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
requested changes
Apr 19, 2024
There was a problem hiding this comment.
Hey @SlayterDev! The changes look good, but I've found some issues while testing – they're related to updating selected tab after closing a few tabs. I've updated unit tests to indicate these failures.
The selection basically needs to be updated (offset by the index of the tab for which all tabs to the left are removed), and the new selection index should be adjusted to the number of remaining tabs.
Let me know if anything is unclear. Thanks!
ayoy
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207117125840765/f
Tech Design URL:
CC: @ayoy
Description:
This PR adds the option to close all tabs to the left when right clicking a tab. It also moves this action as well as "close to right" and "close other tabs" to a submenu in the tab context menu.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation