Remove "Thank You" prompts #2659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only removes the calls to show the prompts themselves. All of the UI classes and copy will be cleaned up on the main branch, this is done to keep the release branch change as small as possible.
jotaemepereira
pushed a commit
that referenced
this pull request
Apr 19, 2024
This only removes the calls to show the prompts themselves. All of the UI classes and copy will be cleaned up on the main branch, this is done to keep the release branch change as small as possible. Task/Issue URL: https://app.asana.com/0/1199230911884351/1207105265255740/f Tech Design URL: CC: **Description**: This PR removes the Thank You prompts that are presented to waitlist users. This is being done because the code is being taken down on the Stripe side next week, so we should no longer show the prompt to waitlist users who haven't yet upgraded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only removes the calls to show the prompts themselves. All of the UI classes and copy will be cleaned up on the main branch, this is done to keep the release branch change as small as possible.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207105265255740/f
Tech Design URL:
CC:
Description:
This PR removes the Thank You prompts that are presented to waitlist users.
This is being done because the code is being taken down on the Stripe side next week, so we should no longer show the prompt to waitlist users who haven't yet upgraded.
Steps to test this PR:
canShowPromptCheck()to always returntrueand check that the prompt doesn't appear when you launch the appInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation