-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background agent metadata for pixels #2607
Add background agent metadata for pixels #2607
Conversation
a1515bb
to
1d47d26
Compare
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/UI/UIMapper.swift
Outdated
Show resolved
Hide resolved
Behavior wise it lgtm, this is the output I get:
|
b694aab
to
7121d4c
Compare
7121d4c
to
82f53fb
Compare
LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/UI/UIMapper.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one nit related to a function name.
Also, the PR checks are not passing, please take a look at it before merging
I do not know about this; it’s a check on a file that I didn’t change |
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206981574273169/f
Tech Design URL:
CC:
Description:
Adds debug metadata for FE pixels in initial scans.
Steps to test this PR:
getDebugMetadata
method from the UI should be called periodically.