Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background agent metadata for pixels #2607

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

jotaemepereira
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199230911884351/1206981574273169/f
Tech Design URL:
CC:

Description:
Adds debug metadata for FE pixels in initial scans.

Steps to test this PR:

  1. Use the custom web UI URL: https://abuliga.duckduckgo.com/dbp
  2. Remove the PIR profile
  3. Start the process again. The getDebugMetadata method from the UI should be called periodically.
  4. Check the logs where the JSON with the information is being returned. Check the information is correct and aligned with the expectations set here: https://app.asana.com/0/0/1207007864668881/f

@jotaemepereira jotaemepereira force-pushed the juan/dbp/background-agent-metadata branch 2 times, most recently from a1515bb to 1d47d26 Compare April 17, 2024 13:08
@THISISDINOSAUR
Copy link
Contributor

Behavior wise it lgtm, this is the output I get:

Metadata: {
  "lastStartedSchedulerOperationBrokerUrl" : "advancedbackgroundchecks.com",
  "lastSchedulerOperationBrokerUrl" : "neighbor.report",
  "lastSchedulerErrorTimestamp" : 1713369789,
  "agentSchedulerState" : "stopped",
  "lastStartedSchedulerOperationTimestamp" : 1713369799,
  "isAgentRunning" : true,
  "lastSchedulerErrorMessage" : "httpError",
  "lastRunAppVersion" : "1.84.0 (build: 165)",
  "lastSchedulerOperationTimestamp" : 1713369796,
  "lastStartedSchedulerOperationType" : "scan",
  "lastSchedulerOperationType" : "scan",
  "lastRunAgentVersion" : "1.84.0 (build: 165)"
}

@jotaemepereira jotaemepereira changed the base branch from main to release/1.84.0 April 19, 2024 12:15
@jotaemepereira jotaemepereira changed the base branch from release/1.84.0 to main April 19, 2024 12:43
@jotaemepereira jotaemepereira changed the base branch from main to release/1.84.0 April 19, 2024 13:00
@jotaemepereira jotaemepereira force-pushed the juan/dbp/background-agent-metadata branch from b694aab to 7121d4c Compare April 19, 2024 13:00
@jotaemepereira jotaemepereira changed the base branch from release/1.84.0 to main April 19, 2024 13:01
@jotaemepereira jotaemepereira force-pushed the juan/dbp/background-agent-metadata branch from 7121d4c to 82f53fb Compare April 19, 2024 13:06
@jotaemepereira jotaemepereira changed the base branch from main to release/1.84.0 April 19, 2024 13:06
Copy link
Collaborator

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one nit related to a function name.
Also, the PR checks are not passing, please take a look at it before merging

@jotaemepereira
Copy link
Collaborator Author

jotaemepereira commented Apr 19, 2024

Also, the PR checks are not passing, please take a look at it before merging

I do not know about this; it’s a check on a file that I didn’t change

@jotaemepereira jotaemepereira merged commit ee5067b into release/1.84.0 Apr 19, 2024
17 checks passed
@jotaemepereira jotaemepereira deleted the juan/dbp/background-agent-metadata branch April 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants