-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically clear data upon quitting #2600
Conversation
… restore on startup
DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
@@ -1,7 +1,7 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<Scheme | |||
LastUpgradeVersion = "1530" | |||
version = "1.8"> | |||
version = "1.7"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Xcode 15.3 artifact, roll back please
static func disableAutoClearToEnableSessionRestore() -> String { | ||
let localized = NSLocalizedString("disable.auto.clear.to.enable.session.restore", | ||
value: "Disable the %@ setting to enable session restore on startup.", | ||
comment: "Information label in Settings. It tells user that to enable session restoration setting they have to disable burn on quit") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comment for translator that %@ will be replaced with the "Auto-Clear" setting name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed %@ and used the same approach you suggested for showDataClearingSettings
let localized = NSLocalizedString("show.data.clearing.settings", | ||
value: "Show %@ Settings.", | ||
comment: "Button in Settings. It navigates user to Data Clearing Settings.") | ||
return String(format: localized, dataClearing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the string format seems misaligned here as it doesn‘t consider declension of nouns ("Очистка данных" -> "Открыть настройки очистк-и- данных"), I think it‘s better to set the whole string for locatizations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @tomasstrba!
Validated data clearing working on quit and on launch after termination.
See minor comments inline
Task/Issue URL: https://app.asana.com/0/1177771139624306/1205062321200340/f
Description:
Adding Burn on Quit feature for macOS. Upon standard exit, data are cleared and the fire animation is presented. If macOS is restarting, the app delays the restart until all data have been cleared. In the event of an unexpected termination, such as a crash or force quit, data clearing is handled at the next startup.
Steps to test this PR:
Test standard application termination with the burn on quit disabled and the session restoration disabled
Test standard application termination with the burn on quit disabled and the session restoration enabled
Test standard application termination with the 'burn on quit' enabled and the 'warn before quit' disabled
Test standard application termination with the 'burn on quit' enabled and the 'warn before quit' enabled
Test unexpected application termination with the 'burn on quit' enabled
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation