Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SettingsVC readding on pane change #2243

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Feb 22, 2024

Task/Issue URL: https://app.asana.com/0/1177771139624306/1206667437436846/f
Tech Design URL:
CC:

Description:

  • fix SettingsVC readding on pane change;
  • fix native ui session restoration losing forward history and re-restoring

Steps to test this PR:

  1. Open settings, switch settings panes, validate hover on rows still works and the "paw" appears on links in settings and remove device in sync
  2. Restart the browser with Reopen all windows session and Settings tab active: when the settings tab is restored - validate it‘s restored to the same pane as before closing; select another settings pane, validate it‘s selected from the first click
  3. Navigate between settings pane, validate no back history items are created for each pane
  4. switch to another tab, switch back to Settings, validate the same pane is still open
  5. Switch to bookmarks, navigate back, validate the same pane is still open
  6. Don‘t close the settings pane; Navigate from a new tab to SERP, to about:bookmarks, to about:settings, validate back/forward is working correctly,
  7. return forward to the settings page, switch another pane; switch to another settings tab, validate selected settings pane is kept for each settings tab when switching.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

…tion losing forward history and re-restoring
Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected

@mallexxx mallexxx merged commit 863266a into main Feb 23, 2024
17 checks passed
@mallexxx mallexxx deleted the alex/fix-settings-hover branch February 23, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants