Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update onboarding copy to comply with App Store #2240

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

samsymons
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199230911884351/1206662058767730/f
Tech Design URL:
CC:

Description:

This PR updates the onboarding copy to specify that beginning the onboarding flow will cause a login item to get added to the system.

Steps to test this PR:

  1. Uninstall NetP from the settings menu
  2. Open the NetP UI
  3. Check that you see copy about the menu bar item being added

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@samsymons samsymons merged commit c1f2a21 into release/1.75.1 Feb 22, 2024
17 checks passed
@samsymons samsymons deleted the sam/release-branch-onboarding-copy branch February 22, 2024 11:43
samsymons added a commit that referenced this pull request Feb 23, 2024
* tag '1.75.1-125':
  Increase build number to 125
  Update onboarding copy to comply with App Store (#2240)
  Release PR: Update NetP invite code copy (#2237)

# Conflicts:
#	Configuration/BuildNumber.xcconfig
#	DuckDuckGo/Common/Localizables/UserText+NetworkProtection.swift
#	DuckDuckGo/Localizable.xcstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants