DBP: Add engagement Pixels #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
commented
Feb 21, 2024
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // |
There was a problem hiding this comment.
I moved the stage calculation pixels to another class. The DataBrokerProtectionPixels class was getting too big.
Bunn
reviewed
Feb 22, 2024
...kerProtection/Sources/DataBrokerProtection/Pixels/DataBrokerProtectionEngagementPixels.swift
Outdated
Show resolved
Hide resolved
Bunn
approved these changes
Feb 22, 2024
@Bunn Yes. When we run the code we always try to fire the three of them. |
jotaemepereira
force-pushed
the
juan/dbp/kpi-urgent-pixels
branch
from
32e0464 to
778bdf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206656675196297/f
Description:
Add engagement pixels (DAU/WAU/MAU) to Data Broker Protection
Steps to test this PR: