Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug vanilla browser #2236

Merged
merged 20 commits into from
Mar 7, 2024
Merged

Debug vanilla browser #2236

merged 20 commits into from
Mar 7, 2024

Conversation

federicocappelli
Copy link
Member

@federicocappelli federicocappelli commented Feb 21, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1206522891480880/f
Tech Design URL: https://app.asana.com/0/0/1206524485561895/f
CC: @jaceklyp @laghee

Description:

This PR adds a vanilla browser to the debug menu.
The browser features are described here
Note:

  • Multi-windows and multi-tab functionalities are simulated just opening a new Vanilla browser window at the new URL.
  • Cookies are shared between the Vanilla Browser windows and are persisted until the app main is closed.

Steps to test this PR:

Basic navigation:

  1. Debug menu > Open vanilla browser
  2. Navigate to any website

New window/Popup:

Cookies retention

  • log in on a website, open a new window and navigate to the same website, the login is retained.

@federicocappelli federicocappelli requested review from jaceklyp and removed request for jaceklyp February 21, 2024 17:02
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/InfoPlist.xcstrings
#	Submodules/privacy-reference-tests
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
@federicocappelli federicocappelli merged commit e018eef into main Mar 7, 2024
13 checks passed
@federicocappelli federicocappelli deleted the fcappelli/bareBonesBrowser branch March 7, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants