Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on demand so that it's not enabled too soon #2235

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Feb 21, 2024

Task/Issue URL: https://app.asana.com/0/1203137811378537/1206543593200557/f

Description:

Enables on-demand only after the VPN has connected.

Testing

  1. Check out BSK 109.0.0
  2. Add it locally to this branch
  3. We want to fake a connection issue that makes the connection take longer to establish, and eventually fails. To do so, replace these lines with the following code:
Task {
    try? await Task.sleep(nanoseconds: 3 * NSEC_PER_SEC)
    completionHandler(NSError(domain: "asd", code: 1))
}
  1. Run the app and try to connect the VPN.
  2. Make sure it fails after ~3 seconds, and that on-demand isn't turned ON for the connection.

If you want to see the issue that was resolved by these changes, add-back this line that was removed and repeat this test.


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@diegoreymendez diegoreymendez self-assigned this Feb 21, 2024
@diegoreymendez diegoreymendez marked this pull request as ready for review February 21, 2024 14:03
@diegoreymendez diegoreymendez changed the base branch from release/1.75.1 to release/1.76.0 February 21, 2024 14:33
@diegoreymendez diegoreymendez merged commit 32da4eb into release/1.76.0 Feb 21, 2024
24 of 25 checks passed
@diegoreymendez diegoreymendez deleted the diego/fix-on-demand-2 branch February 21, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants