Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix firebutton UI #2234

Merged
merged 8 commits into from
Feb 24, 2024
Merged

fix firebutton UI #2234

merged 8 commits into from
Feb 24, 2024

Conversation

SabrinaTardio
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/0/1206628858529169/f

Description: Adjust fire storyboards constraints to address layout issues indicated in task

Steps to test this PR:

  1. Run the app press the fire button and check everything looks as expected
  2. go to edit scheme and in the App Language chose: Double-Lenght pseudolanguage
    3 Run the app press the fire button and check issues visible in the task are addressed

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 21, 2024
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@SabrinaTardio SabrinaTardio removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 23, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 23, 2024
@github-actions github-actions bot removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 23, 2024
@SabrinaTardio SabrinaTardio merged commit a0011be into main Feb 24, 2024
17 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/fix_firebutton_ui branch February 24, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants