Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix onboarding on first launch #2229

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix onboarding on first launch #2229

merged 1 commit into from
Feb 21, 2024

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1177771139624306/1206646111353020/f

Description:

  • fixes onboarding opening on first launch

Steps to test this PR:

  1. run ./clean-app.sh review
  2. launch Review build, validate onboarding is shown;
  3. navigate to about:welcome, validate onboarding is shown
  4. validate onboarding is not shown on 2nd launch

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@ayoy ayoy merged commit f76e8cc into release/1.76.0 Feb 21, 2024
17 of 18 checks passed
@ayoy ayoy deleted the alex/fix-onboarding branch February 21, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants