Enable Stripe purchase flow for internal users in non-App Store target #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miasma13
changed the title
miasma13
changed the title
Bunn
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
- Ensure that "Privacy Pro" purchase entry point item is in the more options menu and none of the 3 paid feature are present there
- Ensure that "Privacy Pro" settings pane is present in the settings.
- Ensure that both from more options menu and settings user can buy subscription via Stripe.
- Ensure that after successful purchase the 3 paid features are accessible via dedicated buttons from:
- purchase onboarding page
- from settings
Bunn
reviewed
Feb 21, 2024
| #endif | ||
| } | ||
|
|
||
| private var isDBPActivated: Bool { |
There was a problem hiding this comment.
I would add a comment here stating that we are using the database state to determine if we have current users using DBP, as we are only concerned with users who have enabled DBP and created a profile in it and not people who redeemed but didn't do anything with it.
samsymons
reviewed
Feb 22, 2024
...ackages/SubscriptionUI/Sources/SubscriptionUI/Preferences/PreferencesSubscriptionModel.swift
Outdated
Show resolved
Hide resolved
samsymons
reviewed
Feb 22, 2024
samsymons
approved these changes
Feb 22, 2024
…on to access the feature
Task/Issue URL: https://app.asana.com/0/0/1206696049032565/f ## Description Updates OpenSSL as part of the maintenance process.
miasma13
force-pushed
the
michal/subscription-on-sparkle
branch
from
a231491 to
0ef4820
Compare
afterxleep
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1206534283150250/f
CC: @samsymons @Bunn
Description:
Enable Stripe purchase flow for internal users in non-App Store target. Following the requirements listed in the linked task we do want to enable the Subscription flow for users that are authenticated as internal users and have not started waitlist interaction with VPN or DBP.
Steps to test this PR:
Please test on "DuckDuckGo Privacy Browser" target/scheme.
--
DebugmenuSubscription->Internal testingDebugmenu:Network Protection->Reset->Reset All StateDebugmenu:Personal Information Removal->Reset All State and Delete All Data--
_Check if Subscription environment toggle (for FE and BE) accessible via
Debugmenu:Subscription->Environmentworks.Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation