DBP: Add initial loading indicator when loading web UI #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bot: not in app board
Bunn
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
LGTM.
The spinner looks just a tiny bit blurry but I noticed that even changing the controlSize to .large it doesn't affect anything.
I'd personally change:
- Set the controlSize to .large
- Remove
loader.widthAnchor.constraint(equalToConstant: Consts.loaderDimension),
loader.heightAnchor.constraint(equalToConstant: Consts.loaderDimension)
and let the system decide the correct size. But if we want it a 50x50 sounds good to me like it is.
All this is nit :) probably not worth to spend more time on this since we'll eventually change to something with designs in the future.
jotaemepereira
force-pushed
the
juan/dbp/add-initial-loading-web-ui
branch
from
a21fcd1 to
cdc2bb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206570989671741/f
Description:
Adds loading indicator when loading the web UI
loading-indicator-50x50.mov
Steps to test this PR: