Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop TabPreview.storyboard #2222

Merged
merged 2 commits into from
Feb 20, 2024
Merged

drop TabPreview.storyboard #2222

merged 2 commits into from
Feb 20, 2024

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/0/1206632173901383/f

Description:

  • Tab Preview View and Window Controllers code-initialiezed

Steps to test this PR:

  1. Validate previews work and look the same for both selected/non-selected tabs
  2. Validate XC Preview works

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from tomasstrba February 19, 2024 09:39
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 19, 2024
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@github-actions github-actions bot removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Feb 20, 2024
@mallexxx mallexxx merged commit 48bbfe1 into main Feb 20, 2024
16 of 17 checks passed
@mallexxx mallexxx deleted the alex/drop-tabpreviews-storyboard branch February 20, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants