-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed address bar cleared/losing focus on Navigation #2157
Merged
Merged
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
03f9bb3
Fixed address bar cleared/losing focus on Navigation
mallexxx 375cbb1
Merge remote-tracking branch 'origin/main' into alex/fix-address-bar-…
mallexxx c5cdd45
Merge remote-tracking branch 'origin/main' into alex/fix-address-bar-…
mallexxx 7b699bf
fixed suggestion window not disappearing on tab switch
mallexxx 3aa45ff
Merge remote-tracking branch 'origin/main' into alex/fix-address-bar-…
mallexxx 8f37cd8
refactor first responder setting and fix address bar blinking issues
mallexxx 7ebe607
fix tests
mallexxx 543f5ba
Merge remote-tracking branch 'origin/main' into alex/fix-address-bar-…
mallexxx 535f92e
Merge remote-tracking branch 'origin/main' into alex/fix-address-bar-…
mallexxx 41ae4cf
fix issues, add tests
mallexxx eeb4e1c
Merge remote-tracking branch 'origin/main' into alex/fix-address-bar-…
mallexxx d0c5643
Merge remote-tracking branch 'origin/main' into alex/fix-address-bar-…
mallexxx 808c5bd
fix comment; fixing tests
mallexxx 3b634cb
Merge remote-tracking branch 'origin/main' into alex/fix-address-bar-…
mallexxx 5684bb5
fix divider shown on the Home Page
mallexxx 52d6f16
Merge remote-tracking branch 'origin/main' into alex/fix-address-bar-…
mallexxx a968834
Merge remote-tracking branch 'origin/main' into alex/fix-address-bar-…
mallexxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -240,7 +240,9 @@ final class AppDelegate: NSObject, NSApplicationDelegate, FileDownloadManagerDel | |
|
||
startupSync() | ||
|
||
stateRestorationManager.applicationDidFinishLaunching() | ||
if [.normal, .uiTests].contains(NSApp.runType) { | ||
stateRestorationManager.applicationDidFinishLaunching() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. disable state restoration for integration tests |
||
} | ||
|
||
BWManager.shared.initCommunication() | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,7 +61,6 @@ final class MainView: NSView { | |
bookmarksBarHeightConstraint = bookmarksBarContainerView.heightAnchor.constraint(equalToConstant: 34) | ||
|
||
navigationBarTopConstraint = navigationBarContainerView.topAnchor.constraint(equalTo: topAnchor, constant: 38) | ||
addressBarHeightConstraint = navigationBarContainerView.heightAnchor.constraint(equalToConstant: 42) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. moved tnis into the Navigation Bar Controller in sake of encapsulation and fluid address bar animation |
||
|
||
NSLayoutConstraint.activate([ | ||
tabBarContainerView.topAnchor.constraint(equalTo: topAnchor), | ||
|
@@ -82,7 +81,6 @@ final class MainView: NSView { | |
navigationBarTopConstraint, | ||
navigationBarContainerView.leadingAnchor.constraint(equalTo: leadingAnchor), | ||
navigationBarContainerView.trailingAnchor.constraint(equalTo: trailingAnchor), | ||
addressBarHeightConstraint, | ||
|
||
webContainerView.topAnchor.constraint(equalTo: bookmarksBarContainerView.bottomAnchor), | ||
webContainerView.bottomAnchor.constraint(equalTo: bottomAnchor), | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really related change but this made UI test at least launchable