Add dataBroker name to DBP email generation #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Works as described where the parameter is added. That said, the resulting email isn't necessarily showing anything specific I can validate against the broker name. I expect this is probably just fine.
Besides this, I've added a comment since I believe we can do a bit more cleanup with this PR.
I'm approving because the comment is non-blocking.
| func getConfirmationLink(from email: String, | ||
| numberOfRetries: Int, | ||
| pollingIntervalInSeconds: Int, | ||
| shouldRunNextStep: @escaping () -> Bool) async throws -> URL | ||
| } | ||
|
|
||
| extension EmailServiceProtocol { | ||
| func getEmail() async throws -> String { |
There was a problem hiding this comment.
It seems like this is no longer used / needed, but that we're using this call for the tests.
Would it be possible to remove this one and update the tests to use the getEmail(dataBrokerName:) variant?
I think that'd help keep the tests more valuable to us.
samsymons
added a commit
that referenced
this pull request
Jan 21, 2024
* main: (37 commits) Fix IPC memory leak (DBP support) (#2092) fix DBP UI at duck://dbp url (#2094) Avoid unnecessary work during bulk drag and drop bookmarks bar operations (#2088) Update URL.isDuckPlayer to return true also for duck scheme URLs (#2093) Add dataBroker name to DBP email generation (#2072) Show/dismiss Privacy Dashboard on mouse-down (#2064) Allow arbitrary content loading for DBP (#2084) The appcast reference fix for version 0.31.7 (#2075) replace app-bound about: urls with duck:// urls (#2061) fix non-Safari DDG iOS bookmarks HTML import (#2039) Import "synced" bookmarks from Chrome&Firefox; Keep original root folders (#2049) Remove alphabetic sorting in Bookmarks Sidebar (#2048) Drop BookmarkTableCellView.xib (#2079) Fix Gatekeeper dialog for binaries downloaded by the browser (#2068) Display "Copy Email Address" context menu action for email links (#2076) add pixels for sync flows (#2056) Sign up with Apple bug fix (#2083) Improve DBP onboarding experience for FE devs (#2082) Prompt for Primary Password for FF Key3.db logins (#2066) Throw error on import database mapping error (#2065) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/inbox/1201011656765575/1206001821973823/1206365925714070
Description:
Add dataBroker name to DBP email generation
Steps to test this PR:
dataBrokerparameter