Fix casing in some copy items in Preferences and Main Menu #2070
+55
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabrinaTardio
approved these changes
Jan 17, 2024
| @@ -135,14 +135,14 @@ struct UserText { | |||
| static let mainMenuViewHome = NSLocalizedString("Home", comment: "Main Menu View item") | |||
| static let mainMenuHomeButton = NSLocalizedString("Home Button", comment: "Main Menu > View > Home Button item") | |||
|
|
|||
| static func mainMenuHomeButton(for position: HomeButtonPosition) -> String { | |||
| static func mainMenuHomeButtonMode(for position: HomeButtonPosition) -> String { | |||
There was a problem hiding this comment.
Personally feels a bit weird to have logic here even if minimal…
samsymons
added a commit
that referenced
this pull request
Jan 18, 2024
* main: Bump BrowserServicesKit Version (#2063) Bump autoconsent to 9.1.0 (#2067) Fix casing in some copy items in Preferences and Main Menu (#2070) Fix vertical alignment of privacy feed shield icon (#2069) Fix giving focus to webView when it's loaded in BrowserTabViewController (#2073) Increase polling interval for captcha solver (#2071) Add a link to help page in location permission popup (#2017) Add bookmark popover in SwiftUI (#2036) Better detection of AMP pages (#2001) UI adjustments for improved VPN user control (#2043) Don't override drop operation if source view is webView (#2058) Bump version to 1.71.0 (104) Set marketing version to 1.71.0 Update embedded files
samsymons
added a commit
that referenced
this pull request
Jan 19, 2024
* main: Fix Gatekeeper dialog for binaries downloaded by the browser (#2068) Display "Copy Email Address" context menu action for email links (#2076) add pixels for sync flows (#2056) Sign up with Apple bug fix (#2083) Improve DBP onboarding experience for FE devs (#2082) Prompt for Primary Password for FF Key3.db logins (#2066) Throw error on import database mapping error (#2065) Bump BrowserServicesKit Version (#2063) Bump autoconsent to 9.1.0 (#2067) Fix casing in some copy items in Preferences and Main Menu (#2070) Fix vertical alignment of privacy feed shield icon (#2069) Fix giving focus to webView when it's loaded in BrowserTabViewController (#2073)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1206074055876149/f
Description:
Update copy casing for Home Button mode, Bookmarks Bar appearance and session restoration settings.
Steps to test this PR:
(Consult Asana task for copy details)
Title Case.Title Case.Title Case.Sentence case.Sentence case.Sentence case.Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation