Fix Gatekeeper dialog for binaries downloaded by the browser #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
commented
Jan 16, 2024
| @@ -423,11 +423,9 @@ extension URL { | |||
| quarantineProperties[kLSQuarantineDataURLKey as String] = sourceURL | |||
| quarantineProperties[kLSQuarantineOriginURLKey as String] = referrerURL | |||
|
|
|||
| if quarantineProperties[kLSQuarantineTypeKey as String] == nil { | |||
There was a problem hiding this comment.
@mallexxx any idea why we're checking for nil here? I'm testing various download types (on a release build vs this branch), such as ICS calendar invitations and they're all unaffected by this change. I suppose we're fine with removing this if statement but let me know if we're not. Thanks!
There was a problem hiding this comment.
I don‘t remember exactly why the check was there probably it‘s just a precaution not to overwrite a default value
samsymons
added a commit
that referenced
this pull request
Jan 19, 2024
* main: Fix Gatekeeper dialog for binaries downloaded by the browser (#2068) Display "Copy Email Address" context menu action for email links (#2076) add pixels for sync flows (#2056) Sign up with Apple bug fix (#2083) Improve DBP onboarding experience for FE devs (#2082) Prompt for Primary Password for FF Key3.db logins (#2066) Throw error on import database mapping error (#2065) Bump BrowserServicesKit Version (#2063) Bump autoconsent to 9.1.0 (#2067) Fix casing in some copy items in Preferences and Main Menu (#2070) Fix vertical alignment of privacy feed shield icon (#2069) Fix giving focus to webView when it's loaded in BrowserTabViewController (#2073)
samsymons
added a commit
that referenced
this pull request
Jan 21, 2024
* main: (37 commits) Fix IPC memory leak (DBP support) (#2092) fix DBP UI at duck://dbp url (#2094) Avoid unnecessary work during bulk drag and drop bookmarks bar operations (#2088) Update URL.isDuckPlayer to return true also for duck scheme URLs (#2093) Add dataBroker name to DBP email generation (#2072) Show/dismiss Privacy Dashboard on mouse-down (#2064) Allow arbitrary content loading for DBP (#2084) The appcast reference fix for version 0.31.7 (#2075) replace app-bound about: urls with duck:// urls (#2061) fix non-Safari DDG iOS bookmarks HTML import (#2039) Import "synced" bookmarks from Chrome&Firefox; Keep original root folders (#2049) Remove alphabetic sorting in Bookmarks Sidebar (#2048) Drop BookmarkTableCellView.xib (#2079) Fix Gatekeeper dialog for binaries downloaded by the browser (#2068) Display "Copy Email Address" context menu action for email links (#2076) add pixels for sync flows (#2056) Sign up with Apple bug fix (#2083) Improve DBP onboarding experience for FE devs (#2082) Prompt for Primary Password for FF Key3.db logins (#2066) Throw error on import database mapping error (#2065) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1177771139624306/1203568220589424/f
Description:
Always overwrite quarantine type to web download or other download to show "DuckDuckGo downloaded this file"
instead of "DuckDuckGo created this file" Gatekeeper dialogs for downloaded binaries.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation