Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt for Primary Password for FF Key3.db logins #2066

Merged
merged 5 commits into from
Jan 18, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Jan 16, 2024

Task/Issue URL: https://app.asana.com/0/0/1206360613908053/f

Description:

  • Adds password prompt for old Firefox (55) password-protected logins import
  • Adds visual differentiation for Browser Profile Picker in Data Import view when there‘re profile with repeated names

Steps to test this PR:

  1. Install FF 55 or other version with Key3.db from https://ftp.mozilla.org/pub/firefox/releases/
  2. Clear ~/Library/Application Support/Firefox/Profiles to create a new profile
  3. Open Settings->Logins and create a new password; Set Master Password for Firefox passwords
  4. Import FF Passwords in DDG:
  5. validate Primary Password is requested. Enter wrong password, validate password is requested again and passwords are imported when valid password is entered
  6. Remove password protection from the profile: validate passwords are still imported

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from ayoy January 16, 2024 11:02
@ayoy ayoy self-assigned this Jan 18, 2024
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this PR is good to go because I'm getting prompted for password as expected. Importing from FF 57 failed for me, but that is likely another issue related to a different database scheme.

@ayoy ayoy assigned mallexxx and unassigned ayoy Jan 18, 2024
@ayoy ayoy self-requested a review January 18, 2024 11:55
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now, great find. Thanks @mallexxx!

@mallexxx mallexxx merged commit bfd2c22 into main Jan 18, 2024
14 checks passed
@mallexxx mallexxx deleted the alex/ff-import-key3-primary-password branch January 18, 2024 12:31
samsymons added a commit that referenced this pull request Jan 19, 2024
* main:
  Fix Gatekeeper dialog for binaries downloaded by the browser (#2068)
  Display "Copy Email Address" context menu action for email links (#2076)
  add pixels for sync flows (#2056)
  Sign up with Apple bug fix (#2083)
  Improve DBP onboarding experience for FE devs (#2082)
  Prompt for Primary Password for FF Key3.db logins (#2066)
  Throw error on import database mapping error (#2065)
  Bump BrowserServicesKit Version (#2063)
  Bump autoconsent to 9.1.0 (#2067)
  Fix casing in some copy items in Preferences and Main Menu (#2070)
  Fix vertical alignment of privacy feed shield icon (#2069)
  Fix giving focus to webView when it's loaded in BrowserTabViewController (#2073)
samsymons added a commit that referenced this pull request Jan 21, 2024
* main: (37 commits)
  Fix IPC memory leak (DBP support) (#2092)
  fix DBP UI at duck://dbp url (#2094)
  Avoid unnecessary work during bulk drag and drop bookmarks bar operations (#2088)
  Update URL.isDuckPlayer to return true also for duck scheme URLs (#2093)
  Add dataBroker name to DBP email generation  (#2072)
  Show/dismiss Privacy Dashboard on mouse-down (#2064)
  Allow arbitrary content loading for DBP (#2084)
  The appcast reference fix for version 0.31.7 (#2075)
  replace app-bound about: urls with duck:// urls (#2061)
  fix non-Safari DDG iOS bookmarks HTML import (#2039)
  Import "synced" bookmarks from Chrome&Firefox; Keep original root folders (#2049)
  Remove alphabetic sorting in Bookmarks Sidebar (#2048)
  Drop BookmarkTableCellView.xib (#2079)
  Fix Gatekeeper dialog for binaries downloaded by the browser (#2068)
  Display "Copy Email Address" context menu action for email links (#2076)
  add pixels for sync flows (#2056)
  Sign up with Apple bug fix (#2083)
  Improve DBP onboarding experience for FE devs (#2082)
  Prompt for Primary Password for FF Key3.db logins (#2066)
  Throw error on import database mapping error (#2065)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants