-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt for Primary Password for FF Key3.db logins #2066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think this PR is good to go because I'm getting prompted for password as expected. Importing from FF 57 failed for me, but that is likely another issue related to a different database scheme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great now, great find. Thanks @mallexxx!
* main: Fix Gatekeeper dialog for binaries downloaded by the browser (#2068) Display "Copy Email Address" context menu action for email links (#2076) add pixels for sync flows (#2056) Sign up with Apple bug fix (#2083) Improve DBP onboarding experience for FE devs (#2082) Prompt for Primary Password for FF Key3.db logins (#2066) Throw error on import database mapping error (#2065) Bump BrowserServicesKit Version (#2063) Bump autoconsent to 9.1.0 (#2067) Fix casing in some copy items in Preferences and Main Menu (#2070) Fix vertical alignment of privacy feed shield icon (#2069) Fix giving focus to webView when it's loaded in BrowserTabViewController (#2073)
* main: (37 commits) Fix IPC memory leak (DBP support) (#2092) fix DBP UI at duck://dbp url (#2094) Avoid unnecessary work during bulk drag and drop bookmarks bar operations (#2088) Update URL.isDuckPlayer to return true also for duck scheme URLs (#2093) Add dataBroker name to DBP email generation (#2072) Show/dismiss Privacy Dashboard on mouse-down (#2064) Allow arbitrary content loading for DBP (#2084) The appcast reference fix for version 0.31.7 (#2075) replace app-bound about: urls with duck:// urls (#2061) fix non-Safari DDG iOS bookmarks HTML import (#2039) Import "synced" bookmarks from Chrome&Firefox; Keep original root folders (#2049) Remove alphabetic sorting in Bookmarks Sidebar (#2048) Drop BookmarkTableCellView.xib (#2079) Fix Gatekeeper dialog for binaries downloaded by the browser (#2068) Display "Copy Email Address" context menu action for email links (#2076) add pixels for sync flows (#2056) Sign up with Apple bug fix (#2083) Improve DBP onboarding experience for FE devs (#2082) Prompt for Primary Password for FF Key3.db logins (#2066) Throw error on import database mapping error (#2065) ...
Task/Issue URL: https://app.asana.com/0/0/1206360613908053/f
Description:
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation