Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import "synced" bookmarks from Chrome&Firefox; Keep original root folders #2049

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Jan 11, 2024

Task/Issue URL: https://app.asana.com/0/1199178362774117/1202793152060312/f

Description:

  • Fixes Chrome "synced" bookmarks not imported
  • Importing "Other Bookmarks", "Mobile Bookmarks" into separate folders when Bookmarks bar is not empty

Steps to test this PR:

  1. Create a Chrome account synced with mobile device, ensure ~/Application Support/Google/Chrome/Default Profile/Bookmarks contains synced bookmarks (Mobile Bookmarks folder in Chrome)
  2. Import Chrome data - validate "synced" bookmarks are imported and sort order after import matches the original
  3. Create a Firefox account synced with mobile device, ensure Mobile bookmarks folder appears in Firefox
  4. Import Firefox data - validate "synced" bookmarks are imported and sort order after import matches the original

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx changed the title Import "synced" bookmarks from Chrome; Keep original root folders Import "synced" bookmarks from Chrome&Firefox; Keep original root folders Jan 16, 2024
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing steps worked for me, and the code looks good. Nice improvement, thanks!

@mallexxx mallexxx merged commit cbdbab3 into main Jan 19, 2024
14 checks passed
@mallexxx mallexxx deleted the alex/chrome-import-synced-bookmarks branch January 19, 2024 06:48
samsymons added a commit that referenced this pull request Jan 21, 2024
* main: (37 commits)
  Fix IPC memory leak (DBP support) (#2092)
  fix DBP UI at duck://dbp url (#2094)
  Avoid unnecessary work during bulk drag and drop bookmarks bar operations (#2088)
  Update URL.isDuckPlayer to return true also for duck scheme URLs (#2093)
  Add dataBroker name to DBP email generation  (#2072)
  Show/dismiss Privacy Dashboard on mouse-down (#2064)
  Allow arbitrary content loading for DBP (#2084)
  The appcast reference fix for version 0.31.7 (#2075)
  replace app-bound about: urls with duck:// urls (#2061)
  fix non-Safari DDG iOS bookmarks HTML import (#2039)
  Import "synced" bookmarks from Chrome&Firefox; Keep original root folders (#2049)
  Remove alphabetic sorting in Bookmarks Sidebar (#2048)
  Drop BookmarkTableCellView.xib (#2079)
  Fix Gatekeeper dialog for binaries downloaded by the browser (#2068)
  Display "Copy Email Address" context menu action for email links (#2076)
  add pixels for sync flows (#2056)
  Sign up with Apple bug fix (#2083)
  Improve DBP onboarding experience for FE devs (#2082)
  Prompt for Primary Password for FF Key3.db logins (#2066)
  Throw error on import database mapping error (#2065)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants