Mute/unmute tab #2019
Mute/unmute tab #2019
Conversation
jotaemepereira
force-pushed
the
juan/mute-unmute-tab
branch
4 times, most recently
from
883d50a to
5db2281
Compare
github-actions
bot
added
the
bot: not in app board
jotaemepereira
force-pushed
the
juan/mute-unmute-tab
branch
from
647cd61 to
1b885a7
Compare
github-actions
bot
removed
the
bot: not in app board
jotaemepereira
force-pushed
the
juan/mute-unmute-tab
branch
2 times, most recently
from
a029857 to
63559d0
Compare
jotaemepereira
force-pushed
the
juan/mute-unmute-tab
branch
2 times, most recently
from
d48f854 to
ef85df2
Compare
There was a problem hiding this comment.
@jotaemepereira terribly sorry for taking so long to review this for you. The code looks very good, only with minor nitpicks. I've also added a comment regarding pinned tab view height, so maybe it's worth double checking, but otherwise since this has passed the Design Review, it should be good to go.
Thanks a lot for your work on this! (and for patience 🙏 )
| @@ -21,8 +21,8 @@ import SwiftUIExtensions | |||
|
|
|||
| struct PinnedTabView: View { | |||
| enum Const { | |||
| static let dimension: CGFloat = 32 | |||
| static let cornerRadius: CGFloat = 6 | |||
| static let dimension: CGFloat = 34 | |||
There was a problem hiding this comment.
I realize that this has passed Design Review, but was this change expected?
The pinned tab item view now appears noticeably taller than a regular tab item view.
There was a problem hiding this comment.
Oh actually it's still pending Design Review, so maybe this comment is legit after all.
There was a problem hiding this comment.
Yes. This was fixed in the latest version I’ve just pushed. I’m going to ask Bryan for a final review.
jotaemepereira
force-pushed
the
juan/mute-unmute-tab
branch
5 times, most recently
from
befff3f to
bb2f083
Compare
WIP: When tabs are getting smaller, there is a constraint that is failing.
jotaemepereira
force-pushed
the
juan/mute-unmute-tab
branch
from
e4f6c70 to
0daa429
Compare
Task/Issue URL: https://app.asana.com/0/1177771139624306/1206259162307448/f
Description:
Adds the mute/unmute tab functionality
Steps to test