Autofill management UI and subdomain matching #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amddg44
changed the title
amddg44
commented
Jan 10, 2024
| @@ -376,8 +385,6 @@ final class PasswordManagementItemListModel: ObservableObject { | |||
| itemsByCategory = itemsByCategory.filter { $0.item(matches: filter) } | |||
| } | |||
|
|
|||
| clearSelection() | |||
There was a problem hiding this comment.
I made this change as part of this PR which broke selection highlighting for non empty states so i've moved this call to line 250 where it is now behaving properly for both empty & non-empty states
afterxleep
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
This looks fine and items are highlighted as expected.
The only thing I've noticed (not related to the changes) is that when I switch to the "Passwords" filter, the current website login is no longer selected by default.
Up to you if you want to review that or add a task for later :)
samsymons
added a commit
that referenced
this pull request
Jan 11, 2024
* main: (24 commits) Autofill management UI and subdomain matching (#2018) Update BSK with autofill 10.0.3 (#2051) display "you can delete passwords file" for Safari (#2050) Bump version to 1.70.0 (101) Update embedded files Fix permission request (#2046) update banner colour (#2044) update banner colour (#2044) Force reload on DBP notifications (#2028) update copy (#2042) Suspend Sync when updating device name (#2037) update copy (#2042) Update Enter Code view in Sync Account Recovery (#2038) Suspend Sync when updating device name (#2037) Extend hover area for address bar's bookmark button over bookmarks bar and tab bar (#2020) Bump version to 1.70.0 (100) Update embedded files DBP remote messaging (#1997) Move Preferences views to SwiftUIExtension package (#2035) Add API to obtain reason why given feature is disabled (#2030) ...
samsymons
added a commit
that referenced
this pull request
Jan 13, 2024
* main: Fix serverlocation in connection notification (#2053) Use GRDB.swift 2.23.0 (upstream 6.32.0, SQLCipher 4.5.5) (#2021) Bump version to 1.70.0 (103) Update embedded files macOS: Fix issue with not being able to add favorites for existing bookmarks in the latest 1.70.0 internal (#2059) Bump version to 1.70.0 (102) Update embedded files Remove observer from DataBrokerProtectionViewController (#2057) Fixes VPN tunnel update logic (#2052) Update Sync dialogs titles (#2055) Autofill management UI and subdomain matching (#2018) Update BSK with autofill 10.0.3 (#2051) display "you can delete passwords file" for Safari (#2050) Add Bookmark modal in SwiftUI (#2032)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1200930669568058/1206195170500835/f
Tech Design URL:
CC:
Description:
Update to autofill management auto selection logic to take subdomains into account + a fix of the highlighting of the selected item
Steps to test this PR:
Passwordsand confirm the logins list is correctly displayedCredit Cardsfrom the dropdown filter and confirm the empty state is correctly displayedInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation