Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds option + click support for our VPN menu to show some useful debu… #2007

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Dec 22, 2023

Task/Issue URL: https://app.asana.com/0/0/1206230773829767/f

Description

Adds debug information to the VPN menu.

Screenshot 2023-12-22 at 11 08 55 PM

Testing

  1. Launch the App
  2. Enable NetP
  3. Make sure our VPN menu app is launched.
  4. Click on the VPN menu normally, no debug info should be shown.
  5. Option + click on the VPN menu, you should see debug information.
  6. Make sure you can select the debug values and right click to copy it (CMD + C doesn't work).

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@diegoreymendez diegoreymendez self-assigned this Dec 22, 2023
@diegoreymendez diegoreymendez marked this pull request as ready for review December 22, 2023 22:09
Copy link
Collaborator

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll restart the failing CI job, looks like it timed out. This has happened a few times lately, not sure what happened to cause it.

@diegoreymendez diegoreymendez merged commit 6925a02 into main Dec 23, 2023
16 checks passed
@diegoreymendez diegoreymendez deleted the diego/vpn-menu-debug-info branch December 23, 2023 01:20
samsymons added a commit that referenced this pull request Dec 24, 2023
# By Diego Rey Mendez (4) and others
# Via Fernando Bunn (2) and GitHub (1)
* main:
  Adds option + click support for our VPN menu to show some useful debu… (#2007)
  Update latency & tunnel failure monitor implementation (#2005)
  Prevents VPNSettings from reporting fake changes (#2004)
  Updates the copy for the VPN status bar item context menu (#2003)
  Implement subscription purchase (#1906)
  DBP: Add m_mac prefix to Pixels (#1952)
  Bump version to 1.69.0 (96)
  Update embedded files
  Update Link Tracking Protection to preserve headers (#1965)
  VPN menus improvements (#1979)
  Data Import ux redo (#1754)
  Fix: "SwiftLintPlugin" must be enabled before it can be used (#1987)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	DuckDuckGo/NavigationBar/View/NavigationBarViewController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants