Update latency & tunnel failure monitor implementation #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
diegoreymendez
approved these changes
Dec 22, 2023
samsymons
added a commit
that referenced
this pull request
Dec 24, 2023
# By Diego Rey Mendez (4) and others # Via Fernando Bunn (2) and GitHub (1) * main: Adds option + click support for our VPN menu to show some useful debu… (#2007) Update latency & tunnel failure monitor implementation (#2005) Prevents VPNSettings from reporting fake changes (#2004) Updates the copy for the VPN status bar item context menu (#2003) Implement subscription purchase (#1906) DBP: Add m_mac prefix to Pixels (#1952) Bump version to 1.69.0 (96) Update embedded files Update Link Tracking Protection to preserve headers (#1965) VPN menus improvements (#1979) Data Import ux redo (#1754) Fix: "SwiftLintPlugin" must be enabled before it can be used (#1987) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/NavigationBar/View/NavigationBarViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206209663744590/f and https://app.asana.com/0/0/1206212872939262/f
Description:
Updates the monitor implementation to use Task to address situations when timer is launched multiple times.
Steps to test this PR:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation