DBP remote messaging #1997
Merged
DBP remote messaging #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# By Dominik Kapusta (2) and others # Via GitHub * main: Make sure when we set custom config url, we don't expect etag in return (#1994) Add PixelKit source parameter (#1989) Fix internal user toggling (#2000) Show alert and display warning icon in Sync Settings when data syncing is disabled (#1996) DBP: Integrate subscription account authentication to DBP (#1995) Improve bookmarks html reader (#1986) Add Sync feature flags (#1992) Add daily stats pixel (#1993) Do not reload DBP tab when switching to it (#1942) Fix: external application requests via redirect URLs shows wrong origin. (#1900) # Conflicts: # DuckDuckGo/Statistics/PixelEvent.swift
Bunn
reviewed
Dec 22, 2023
DuckDuckGo/DBP/RemoteMessaging/DataBrokerProtectionRemoteMessaging.swift
Outdated
Show resolved
Hide resolved
DuckDuckGo/DBP/RemoteMessaging/DataBrokerProtectionRemoteMessaging.swift
Outdated
Show resolved
Hide resolved
# By Dax the Duck (6) and others # Via Fernando Bunn (2) and others * main: (36 commits) Send VPN system extension crashes to Sentry (#2002) Update login item failure pixel (#2024) fix turn off sync error message (#2025) DBP: macOS - Scheduler Progress Notifications (#2023) DBP: Implement sign-out flow for DBP (#2009) Switch CI to Xcode 15.1 (#2022) fix(duckplayer): bump CSS for duckplayer nav loop fix (#1982) Bump Submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2006) Bump version to 1.69.0 (99) DBP: Respect foreign constraints when deleting all user's data (#2014) DBP: Respect foreign constraints when deleting all user's data (#2014) Don't force reload tab when restoring state (#2016) Bump version to 1.69.0 (98) Update embedded files Update NetP launch agent logic to include build number (#2015) Always use 'sandbox' Application Support directory for Favicons Fetcher (#2013) Allow calculations in the address bar (#2012) Fix clickable area for buttons in 'Sync with Another Device' view (#2011) Fix for empty autofill state displayed on top of existing password items (#1998) Update error messages (#1999) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Statistics/PixelEvent.swift
Bunn
reviewed
Jan 9, 2024
Bunn
reviewed
Jan 9, 2024
Bunn
reviewed
Jan 9, 2024
Bunn
approved these changes
Jan 9, 2024
Bunn
reviewed
Jan 9, 2024
# By Dominik Kapusta (3) and others # Via GitHub * main: Move Preferences views to SwiftUIExtension package (#2035) Add API to obtain reason why given feature is disabled (#2030) Removes Home-button temporary pixels (#2027) add rollout banner (#2031) Update Enter Code view in Sync Settings (#2029) Use checkboxes instead of switches for Sync Settings options (#2026) # Conflicts: # DuckDuckGo/Statistics/PixelEvent.swift # DuckDuckGo/Statistics/PixelParameters.swift
samsymons
added a commit
that referenced
this pull request
Jan 11, 2024
* main: (24 commits) Autofill management UI and subdomain matching (#2018) Update BSK with autofill 10.0.3 (#2051) display "you can delete passwords file" for Safari (#2050) Bump version to 1.70.0 (101) Update embedded files Fix permission request (#2046) update banner colour (#2044) update banner colour (#2044) Force reload on DBP notifications (#2028) update copy (#2042) Suspend Sync when updating device name (#2037) update copy (#2042) Update Enter Code view in Sync Account Recovery (#2038) Suspend Sync when updating device name (#2037) Extend hover area for address bar's bookmark button over bookmarks bar and tab bar (#2020) Bump version to 1.70.0 (100) Update embedded files DBP remote messaging (#1997) Move Preferences views to SwiftUIExtension package (#2035) Add API to obtain reason why given feature is disabled (#2030) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206209106966759/f
Tech Design URL:
CC:
Description:
This PR adds support for showing remote messages to DBP users.
Steps to test this PR:
WaitlistActivationDateStoreand editdaysSinceActivation()to return10(or some higher value)Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation