Improve bookmarks html reader #1986
Conversation
There was a problem hiding this comment.
This works great @mallexxx! I left just a tiny comment, but all looks good and works perfectly fine. I tested also with some of my test HTML files, with no issues whatsoever.
One more thing – there's a readme file outlining bookmarks HTML reader working principle, nicely hidden in the repository: https://github.com/duckduckgo/macos-browser/tree/main/DuckDuckGo/DataImport/Bookmarks/HTML. It's definitely outdated with your changes, so we can either delete it or try to update it (I created it while adding HTML import hoping that it would be helpful to others, you of course seem to have dealt with it without extra resources, but maybe it's worth to keep these diagrams up to date for posterity (and maybe move them elsewhere).
Thanks again for the patch!
| @@ -12953,6 +12976,14 @@ | |||
| version = 2.5.1; | |||
| }; | |||
| }; | |||
| B65CD8C92B316DF100A595BB /* XCRemoteSwiftPackageReference "swift-snapshot-testing" */ = { | |||
| isa = XCRemoteSwiftPackageReference; | |||
| repositoryURL = "https://github.com/pointfreeco/swift-snapshot-testing"; | |||
There was a problem hiding this comment.
Thanks for adding this, it's a great library!
|
Thanks, @ayoy! I‘ve updated the readme file and added it to the project so it‘s visible |
# By Dominik Kapusta (41) and others # Via Dominik Kapusta (9) and others * main: (138 commits) Make sure when we set custom config url, we don't expect etag in return (#1994) Add PixelKit source parameter (#1989) Fix internal user toggling (#2000) Show alert and display warning icon in Sync Settings when data syncing is disabled (#1996) DBP: Integrate subscription account authentication to DBP (#1995) Improve bookmarks html reader (#1986) Add Sync feature flags (#1992) Add daily stats pixel (#1993) Do not reload DBP tab when switching to it (#1942) Fix: external application requests via redirect URLs shows wrong origin. (#1900) Update clean-app.sh to work on macOS Sonoma and include NetP containers (#1988) Fix: "SwiftLintPlugin" must be enabled before it can be used (#1987) Prevent VPN server list persistence failures (#1985) add test can remove data (#1980) Remove VPN upgrade card (#1983) Fix low-res VPN warning asset (#1984) DBP: Fix unreliable date tests (#1981) Add search retention pixel for NetP (#1964) Sabrina/sync e2e tests (#1959) swiftlint build plugin (#1318) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Application/AppDelegate.swift
# By Dominik Kapusta (2) and others # Via GitHub * main: Make sure when we set custom config url, we don't expect etag in return (#1994) Add PixelKit source parameter (#1989) Fix internal user toggling (#2000) Show alert and display warning icon in Sync Settings when data syncing is disabled (#1996) DBP: Integrate subscription account authentication to DBP (#1995) Improve bookmarks html reader (#1986) Add Sync feature flags (#1992) Add daily stats pixel (#1993) Do not reload DBP tab when switching to it (#1942) Fix: external application requests via redirect URLs shows wrong origin. (#1900) # Conflicts: # DuckDuckGo/Statistics/PixelEvent.swift
Task/Issue URL: https://app.asana.com/0/0/1206196320966558/f
Description:
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation