added protectionsState to breakage form submissions #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
shakyShane
requested review from
ayoy and
miasma13
and removed request for
ayoy
miasma13
approved these changes
Nov 6, 2023
Comment on lines
+40
to
+43
| enum ProtectionsState: String { | ||
| case enabled = "1" | ||
| case disabled = "0" | ||
| } |
There was a problem hiding this comment.
- Not sure what is the expected way of extending the values range here, but maybe a simple bool would suffice?
- Either with the above change or not I suggest replacing "1"/"0" to "true"/"false" to be consistent with other parameters.
There was a problem hiding this comment.
@miasma13 as we discussed in MM - this mapping to "1" | "0" was done intentionally to match what 'other' platforms are doing with this parameter - since I'm adding to all 5 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205839123798770/f
Tech Design URL:
CC:
Description:
Adds a new parameter to breakage form submissions
Steps to test this PR:
protectionsStatehas either a "0" or "1" value based on the rules mentioned in the Asana task.Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation