Add extra dependencies for WaitListViewModel #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
reviewed
Nov 1, 2023
| import Foundation | ||
| import UserNotifications | ||
|
|
||
| protocol WaitlistTermsAndConditionsActionHandler { |
There was a problem hiding this comment.
I considered making this even more generic - basically having a way to inject generic steps which have an action, and then it's up that step to decide what that action is. But I think for our purposes, this is great - nice work. 👍
samsymons
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204167627774280/1205346513220653/f
Description:
In-between PR to refactor the WaitListViewModel to accept extra dependencies and make it more generic
Steps to test this PR: