Add toggling of NetP Notifications to iOS #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
samsymons
approved these changes
Oct 31, 2023
…tifications-settings
diegoreymendez
pushed a commit
that referenced
this pull request
Nov 1, 2023
Task/Issue URL: https://app.asana.com/0/0/1205768725084797/f BSK: duckduckgo/BrowserServicesKit#541 **Description**: These changes are for iOS and doesn’t include any logical changes for macOS. Just creates a some classes that need to be injected and are currently not on macOS. **Steps to test this PR**: 1. CI should be enough but you can try to build this manually as a sanity check. Have a look at the BSK PR first perhaps to get the idea. --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205768725084797/f
BSK: duckduckgo/BrowserServicesKit#541
Description:
These changes are for iOS and doesn’t include any logical changes for macOS. Just creates a some classes that need to be injected and are currently not on macOS.
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation