Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset bookmarks sync timestamp after migrating to FFS favorites #1755

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Oct 13, 2023

Task/Issue URL: https://app.asana.com/0/0/1205710208879158/f

Description:
After migration to form-factor specific favorites is done, reset the timestamp
of bookmarks syncable model to force full remote data fetch to populate
FFS favorites folders that may have previously been skipped.

Steps to test this PR:

  1. Launch the macOS DMG app from Xcode from develop branch.
  2. Sign up to Sync.
  3. Launch the macOS App Store app from this branch.
  4. Add some favorites to the App Store app.
  5. Connect App Store app to DMG app's Sync account, display form factor specific favorites (default setting).
  6. Verify that both apps have the same set of favorites.
  7. Delete a favorite on the DMG app. Verify that it's not deleted from the App Store app (that displays desktop favorites that were unaffected by a change made on DMG app).
  8. Run DMG app from this branch.
  9. Verify that DMG app displays the previously deleted favorite.

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy requested a review from bwaresiak October 13, 2023 10:47
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoy ayoy merged commit aef8698 into dominik/sync-ffs-favorites Nov 3, 2023
16 checks passed
@ayoy ayoy deleted the dominik/sync-ffs-favorites-reset-bookmarks-timestamp branch November 3, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants