Add new browser import sources and bitwarden #1735
Conversation
There was a problem hiding this comment.
@mallexxx I can get the app to crash in the following scenario:
- Have Coc Coc installed, but never run it
- Go to import bookmarks in our browser
- Select Coc Coc on the list
- Crash
If I manually create a directory at ~/Library/Application Support/Coccoc, then Coc Coc disappears from the list and can't be selected. This seems to be the case with other browsers too – if the app is installed but never launched, it appears in the import sources list but makes the app crash when selected.
Another (less important) issue is that when I installed Yandex but skipped the initial setup and went straight to browsing the web, importing data from Yandex causes the "Sorry, we weren't able to import your data." dialog to show up. I'd expect "Imported 0 Bookmarks" instead.
|
@ayoy, the assertion was probably because of wrong condition check in |
|
About the Yandex issue - let‘s keep it as a follow-up because the same is valid for importing passwords from a Chromium browser without any passwords saved - having the passwords checkbox checked and getting an error is confusing but unchecking the checkbox fixes the thing - we‘ve got some reports about it and there‘s a task in the project for this: https://app.asana.com/0/0/1204180319229906/f Probably the checkbox should be disabled on the import screen if we can‘t detect the needed file |
There was a problem hiding this comment.
Looks and works great now! Thanks @mallexxx! 🎉
I'm leaving one tiny thing I've found while reviewing. It would make sense to update copy for Tor Browser import to not mention Firefox. Otherwise import works reliable for all new browsers 💪
…urces; Update Firefox MoreInfo to include actual browser name
Task/Issue URL: https://app.asana.com/0/1199178362774117/1202408404935489/f **Description**: - Added Bitwarden CSV Import Source - Refactored CSV parser: - parsing was incorrectly handling quote characters escaped by backslash but should be double quotes instead - now passwords with \ and " should be imported correctly - Improved CSV headers detection to support Bitwarden, Zoho (general + vault formats), RoboForm, Dashlane **Steps to test this PR**: 1. Validate CSV import from password managers stated above as well as existing CSV integrations (1Password, LastPass, Safari) <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
mallexxx
changed the title
|
continued in #1754 |
Task/Issue URL: https://app.asana.com/0/0/1205457795786502/f
Description:
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation