Fixes startup options reset #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
commented
Sep 3, 2023
| @@ -30,7 +30,7 @@ final class NetworkProtectionOnboardingMenu: NSMenu { | |||
| import NetworkProtection | |||
| import NetworkProtectionUI | |||
|
|
|||
| /// Implements the logic for Network Protection's simulate failures menu. | |||
| /// Implements the logic for Network Protection's onboarding menu. | |||
There was a problem hiding this comment.
Just an unrelated documentation error.
diegoreymendez
commented
Sep 3, 2023
| @@ -318,7 +318,7 @@ final class NetworkProtectionTunnelController: NetworkProtection.TunnelControlle | |||
|
|
|||
| if Self.simulationOptions.isEnabled(.tunnelFailure) { | |||
| Self.simulationOptions.setEnabled(false, option: .tunnelFailure) | |||
| options[NetworkProtectionOptionKey.tunnelFailureSimulation] = NetworkProtectionOptionValue.true | |||
| options[NetworkProtectionOptionKey.tunnelFailureSimulation] = NSNumber(value: true) | |||
There was a problem hiding this comment.
Just standardizing since we get other bools as numbers.
graeme
approved these changes
Sep 12, 2023
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 12, 2023
Task/Issue URL: https://app.asana.com/0/0/1205466155643247/f iOS PR: duckduckgo/iOS#2003 macOS PR: duckduckgo/macos-browser#1581 What kind of version bump will this require?: Patch ## Description Fixes tunnel startup options handling, and improves the options loading mechanism to make it unit testable. --- * Fixes startup options reset * Makes a correction to my previous commits * WIP * WIP * Adds unit tests for StartupOptions * Fixes some swiftlint warnings and improves the code
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Sep 12, 2023
Network Protection: Connection Tester Task/Issue URL: https://app.asana.com/0/0/1205465612515839/f BSK PR: duckduckgo/BrowserServicesKit#489 macOS PR: duckduckgo/macos-browser#1581 ## Description Fixes startup options reset, and improves the options loading logic so we can easily unit test it.
samsymons
added a commit
that referenced
this pull request
Sep 17, 2023
# By Alexey Martemyanov (8) and others # Via GitHub * develop: Clean up login titles at insert and update + migration (#1605) Changes for DBP internal release (#1621) Fix NetP builds in the DBP target (#1627) Put Sparkle behind a new SPARKLE flag (#1616) prevent WKFullScreenWindowController crashing after `close` call (#1618) Use Development environment for Sync by default in Debug builds (#1625) disable flaky testWhenAutoconsentDisabled_promptIsDisplayed (#1619) Prevent crash on database init failure (#1617) Address bar refactoring (#1610) Switch Sync environment to production (#1622) Fixes startup options reset (#1581) perform Email Keychain migration only once (#1600) Fix NetP embedding in DBP builds (#1614) Bump version to 1.56.0 (58) Update embedded files fix Package.resolved New deployment target set to 11.4 (#1592) # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Main/Main.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205465612515839/f
BSK PR: duckduckgo/BrowserServicesKit#489
iOS PR: duckduckgo/iOS#2003
Description
Fixes startup options reset, and improves the options loading logic so we can easily unit test it.
Testing
Test the connection tester
sudo pfctl -ef ~/Desktop/ruleset.txtruleset.txt
Test the connection
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation